Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

19559 cannot see full label easily #19564

Merged

Conversation

jmichot-exotec
Copy link
Contributor

@jmichot-exotec jmichot-exotec commented Nov 10, 2023

Comprehensive Summary of your change

Added css to see full label on hover

Issue being fixed

Fixes #19559
Closes #19559

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

Julien Michot added 2 commits November 10, 2023 08:56
@jmichot-exotec jmichot-exotec force-pushed the 19559-cannot-see-full-label-easily branch from ae3c8ec to 608d108 Compare November 10, 2023 07:56
Signed-off-by: jmichot-exotec <[email protected]>
@jmichot-exotec jmichot-exotec marked this pull request as ready for review November 10, 2023 07:58
@jmichot-exotec jmichot-exotec requested a review from a team as a code owner November 10, 2023 07:58
@AllForNothing AllForNothing added the release-note/update Update or Fix label Nov 10, 2023
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #19564 (af3614c) into main (3a9d68a) will decrease coverage by 22.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19564       +/-   ##
===========================================
- Coverage   67.53%   45.29%   -22.24%     
===========================================
  Files         990      244      -746     
  Lines      109021    13318    -95703     
  Branches     2719     2719               
===========================================
- Hits        73626     6033    -67593     
+ Misses      31432     6982    -24450     
+ Partials     3963      303     -3660     
Flag Coverage Δ
unittests 45.29% <ø> (-22.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 750 files with indirect coverage changes

@AllForNothing
Copy link
Contributor

@jmichot-exotec Thanks for the PR to improve the label view.
Usually, we use the title property to show the full content for a hover action. Could you update your PR with the 'title way'?

@jmichot-exotec
Copy link
Contributor Author

'title way'?

Hello, no problem, I'll do it with the title way

@jmichot-exotec
Copy link
Contributor Author

@AllForNothing modification done on label hover !

@AllForNothing AllForNothing enabled auto-merge (squash) November 13, 2023 02:13
Copy link
Contributor

@AllForNothing AllForNothing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing AllForNothing merged commit 219e4ba into goharbor:main Nov 13, 2023
11 of 12 checks passed
@OrlinVasilev
Copy link
Member

@jmichot-exotec congrats on merging your first PR here :))) welcome to the club

altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
* modified label css to allow hover on it

Signed-off-by: Julien Michot <[email protected]>

* modified label css to allow hover on it

Signed-off-by: Julien Michot <[email protected]>

* Update common.scss

Signed-off-by: jmichot-exotec <[email protected]>

* used title way to show full label on hover

Signed-off-by: Julien Michot <[email protected]>

---------

Signed-off-by: Julien Michot <[email protected]>
Signed-off-by: jmichot-exotec <[email protected]>
Co-authored-by: Julien Michot <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/update Update or Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot see full label easily
6 participants